fix(github): emit resolvable co-author noreply emails - #1704
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
risk: medium
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 54fd0c9. Configure here.
| destination: context.destination, | ||
| events: input.events, | ||
| expiresAtMs: Date.now() + RESOURCE_SUBSCRIPTION_DEFAULT_TTL_MS, | ||
| intent: input.intent, |
There was a problem hiding this comment.
Resource subscriptions drop destination
High Severity
Plugin resourceEvents.subscribe() no longer passes destination into createResourceEventSubscription. That field is required to build the subscription id, store the Slack team, and match inbound events. Plugin-created watches, including GitHub PR follow-up after create, fail instead of routing events back to the conversation.
Reviewed by Cursor Bugbot for commit 54fd0c9. Configure here.
There was a problem hiding this comment.
Not a regression from this PR. destination was intentionally removed from resource-event subscriptions in #1706 (fix(resource-events): let conversations own watch routing). Main and this branch both omit it; the store API no longer accepts destination. Bugbot is comparing against the pre-#1706 merge base.
When the current run actor has a linked GitHub identity, stamp Co-Authored-By with id+login@users.noreply.github.com so downstream assignee automation can resolve a login. Keep trailer generation pure and resolve the current user once through the existing users.resolveActor contract. Co-Authored-By: David Cramer <david@sentry.io>
54fd0c9 to
c36ec49
Compare
github-actions
Bot
added
risk: high
|
3 screenshot changes — 3 changed · 0 added · 0 removed Review screenshots in Frameshift
|
2 participants
Junior already stamps requester
Co-Authored-Bytrailers, but they used the Slack/work email. Downstream automation (like sentry-cocoa's unreferenced-PR issue creator) needs a GitHub login to assign the human instead of the bot.When a linked GitHub identity exists, prefer
id+login@users.noreply.github.comin the trailer so assignee resolution is deterministic. Falls back to the existing actor email when no GitHub link is present.Requested by Thomas Hedderwick.
--
View Junior Session [Sentry]